pkg/settings/limits: add RangeLimiter by jmank88 · Pull Request #1893 · smartcontractkit/chainlink-common

jmank88 · 2026-03-11T21:59:20Z

This PR adds a RangeLimiter for checking that a value is within a range. It is a variation of the BoundLimiter implementation, but takes a Range[N] limit and emits two metrics for lower and upper bounds.

tests

github-actions · 2026-03-11T22:00:38Z

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

⚠️ Breaking Changes (12)

`pkg/loop.(*RelayerService)` (1)

FinalizedHead — 🗑️ Removed

`pkg/loop/mocks` (1)

Relayer_FinalizedHead_Call — 🗑️ Removed

`pkg/loop/mocks.(*Relayer)` (1)

FinalizedHead — 🗑️ Removed

`pkg/loop/mocks.(*Relayer_Expecter)` (1)

FinalizedHead — 🗑️ Removed

`pkg/types` (1)

UnimplementedChainService — 🗑️ Removed

`pkg/types.(*UnimplementedRelayer)` (1)

FinalizedHead — 🗑️ Removed

`pkg/types.ChainService` (2)

FinalizedHead — 🗑️ Removed
FinalizedHead, method set of Relayer — 🗑️ Removed

`pkg/types/core.Relayer` (1)

FinalizedHead — 🗑️ Removed

`pkg/types/core/mocks` (1)

Relayer_FinalizedHead_Call — 🗑️ Removed

`pkg/types/core/mocks.(*Relayer)` (1)

FinalizedHead — 🗑️ Removed

`pkg/types/core/mocks.(*Relayer_Expecter)` (1)

FinalizedHead — 🗑️ Removed

✅ Compatible Changes (8)

`pkg/settings` (3)

ParseRangeFn — ➕ Added
Range — ➕ Added
TimeRange — ➕ Added

`pkg/settings/cresettings.Workflows` (1)

FeatureMultiTriggerExecutionIDsActivePeriod — ➕ Added

`pkg/settings/limits` (4)

ErrorRangeLimited — ➕ Added
MakeRangeLimiter — ➕ Added
NewRangeLimiter — ➕ Added
RangeLimiter — ➕ Added

📄 View full apidiff report

pkg/settings/limits/range.go

pkg/settings/cresettings/settings.go

pkg/settings/limits/range_test.go

jmank88 requested review from bolekk and prashantkumar1982 March 11, 2026 21:59

jmank88 temporarily deployed to integration March 11, 2026 21:59 — with GitHub Actions Inactive

github-code-quality bot found potential problems Mar 11, 2026

View reviewed changes

pkg/settings/limits/range.go Fixed Show fixed Hide fixed

bolekk reviewed Mar 11, 2026

View reviewed changes

pkg/settings/cresettings/settings.go Outdated Show resolved Hide resolved

jmank88 force-pushed the range-limiter branch from fb01a10 to 244df4d Compare March 13, 2026 01:34

jmank88 temporarily deployed to integration March 13, 2026 01:34 — with GitHub Actions Inactive

jmank88 force-pushed the range-limiter branch from 244df4d to 856a3d4 Compare March 13, 2026 01:41

jmank88 had a problem deploying to integration March 13, 2026 01:41 — with GitHub Actions Error

jmank88 force-pushed the range-limiter branch from 856a3d4 to f182583 Compare March 13, 2026 01:43

jmank88 temporarily deployed to integration March 13, 2026 01:43 — with GitHub Actions Inactive

jmank88 requested a review from pavel-raykov March 13, 2026 14:05

pavel-raykov previously approved these changes Mar 13, 2026

View reviewed changes

jmank88 dismissed pavel-raykov’s stale review via 18aa66b March 17, 2026 20:24

jmank88 force-pushed the range-limiter branch from f182583 to 18aa66b Compare March 17, 2026 20:24

jmank88 requested a review from bolekk March 17, 2026 20:24

jmank88 temporarily deployed to integration March 17, 2026 20:24 — with GitHub Actions Inactive

jmank88 commented Mar 17, 2026

View reviewed changes

pkg/settings/cresettings/settings.go Outdated Show resolved Hide resolved

jmank88 marked this pull request as ready for review March 17, 2026 20:27

jmank88 requested a review from a team as a code owner March 17, 2026 20:27

jmank88 requested a review from pavel-raykov March 17, 2026 20:27

bolekk previously approved these changes Mar 17, 2026

View reviewed changes

pkg/settings/cresettings/settings.go Outdated Show resolved Hide resolved

jmank88 dismissed bolekk’s stale review via b2dd29b March 17, 2026 21:27

jmank88 force-pushed the range-limiter branch from 18aa66b to b2dd29b Compare March 17, 2026 21:27

jmank88 requested a review from bolekk March 17, 2026 21:27

jmank88 had a problem deploying to integration March 17, 2026 21:27 — with GitHub Actions Failure

jmank88 temporarily deployed to integration March 17, 2026 21:27 — with GitHub Actions Inactive

jmank88 enabled auto-merge March 17, 2026 21:27

pavel-raykov reviewed Mar 18, 2026

View reviewed changes

pkg/settings/limits/range_test.go Outdated Show resolved Hide resolved

pkg/settings/limits: add RangeLimiter

057152c

jmank88 force-pushed the range-limiter branch from b2dd29b to 057152c Compare March 18, 2026 13:03

jmank88 temporarily deployed to integration March 18, 2026 13:03 — with GitHub Actions Inactive

jmank88 had a problem deploying to integration March 18, 2026 13:03 — with GitHub Actions Failure

jmank88 temporarily deployed to integration March 18, 2026 13:03 — with GitHub Actions Inactive

jmank88 requested a review from pavel-raykov March 18, 2026 13:03

pavel-raykov approved these changes Mar 18, 2026

View reviewed changes

bolekk approved these changes Mar 18, 2026

View reviewed changes

jmank88 added this pull request to the merge queue Mar 18, 2026

github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Mar 18, 2026

You're not authorized to push to this branch. Visit "About protected branches" for more information.

jmank88 added this pull request to the merge queue Mar 18, 2026

Merged via the queue into main with commit 90539fa Mar 18, 2026
31 of 34 checks passed

jmank88 deleted the range-limiter branch March 18, 2026 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkg/settings/limits: add RangeLimiter#1893

pkg/settings/limits: add RangeLimiter#1893
jmank88 merged 1 commit intomainfrom
range-limiter

jmank88 commented Mar 11, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jmank88 commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (12)

pkg/loop.(*RelayerService) (1)

pkg/loop/mocks (1)

pkg/loop/mocks.(*Relayer) (1)

pkg/loop/mocks.(*Relayer_Expecter) (1)

pkg/types (1)

pkg/types.(*UnimplementedRelayer) (1)

pkg/types.ChainService (2)

pkg/types/core.Relayer (1)

pkg/types/core/mocks (1)

pkg/types/core/mocks.(*Relayer) (1)

pkg/types/core/mocks.(*Relayer_Expecter) (1)

✅ Compatible Changes (8)

pkg/settings (3)

pkg/settings/cresettings.Workflows (1)

pkg/settings/limits (4)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmank88 commented Mar 11, 2026 •

edited

Loading

github-actions bot commented Mar 11, 2026 •

edited

Loading

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

`pkg/loop.(*RelayerService)` (1)

`pkg/loop/mocks` (1)

`pkg/loop/mocks.(*Relayer)` (1)

`pkg/loop/mocks.(*Relayer_Expecter)` (1)

`pkg/types` (1)

`pkg/types.(*UnimplementedRelayer)` (1)

`pkg/types.ChainService` (2)

`pkg/types/core.Relayer` (1)

`pkg/types/core/mocks` (1)

`pkg/types/core/mocks.(*Relayer)` (1)

`pkg/types/core/mocks.(*Relayer_Expecter)` (1)

`pkg/settings` (3)

`pkg/settings/cresettings.Workflows` (1)

`pkg/settings/limits` (4)